-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update images of guide/README.md #4272
Update images of guide/README.md #4272
Conversation
43c0c47
to
fe3299c
Compare
fe3299c
to
a704a74
Compare
❌ Some Jest tests failed. Please check the logs and fix the issues before merging. Failed Tests:
|
I am not sure it is worth replacing the SVG with PNG embedded in SVG. The differences are really cosmetic in almost every case. There are issues with the pitchslider images. The sliders are set to the same position even though the pitches are different. It doesn't make sense. |
I agree, the changes are trivial. I would change the core svg instead of embedding png in svg. Would you suggest a rebase for all the above images or a separate PR? |
Your changes to the text of the README are good. We need to fix the pitchslider images (SVG version). I think we can drop the other changes. Might be easiest in a new PR. |
I have reviewed the guide, and it appears that the sliders are intended to be in the same position. I tested this behavior in both the master branch and the deployed version, and it seems to align with the original design intent.
|
OK. |
Summary
This Pull Request replaces the outdated images with the updated ones. It is a follow-up of #4243.
Changes introduced
Checklist